Hi all, the @owner directive seems like a very useful tool for streamlining the review process and adding the “right” people to review schema changes in a PR, rather than having a long list of gatekeepers.
I’m curious if anyone has implemented something similar for Schema Proposals in Apollo Studio? My organization is looking to leverage this directive in a very similar way to what these docs say, but instead applying reviewers on a Github PR, applying reviewers on a Schema Proposal.
@greg-apollo gave a great talk on ownership. But not sure if Wayfair ties it to schema proposals. @Serey_Morm ?
Using the GraphOS platform API this is possible today that you could script setting the reviewers on a proposal
mutation UpdateRequestedReviewers($input: UpdateRequestedReviewersInput!, $name: String!, $graphId: ID!) {
graph(id: $graphId) {
variant(name: $name) {
proposal {
... on ProposalMutation {
updateRequestedReviewers(input: $input) {
}
}
}
}
}
}
While I was still at Wayfair, the plan was to tie it into proposals. Ownership reviews at PR time, while useful, are a little late in the game. I believe it’s best to get the right people involved when designing the API rather than wait until it’s implemented to ask “what do you think?”
What Shane is suggesting was the plan.
You can also enforce your own review limits (say, one reviewer from every changed subgraph has to approve) by subscribing to Proposal changes and the GraphOS Platform API.
Thank you @greg-apollo & @shanemyrick! I had actually viewed your talk at summit this year, and this was the inspiration behind it all!
I will try this solution out and be sure to share it back with community 
To help clarify here is a filled out mutation you could make
mutation UpdateRequestedReviewers {
graph(id: "graph id") {
variant(name: "graph variant aka proposal id") {
proposal {
... on ProposalMutation {
updateRequestedReviewers(input: {
reviewerUserIdsToAdd: ["123"]
reviewerUserIdsToRemove: ["123"]
}) {
__typename
... on Proposal {
displayName
id
status
}
... on PermissionError {
message
}
... on Error {
message
}
}
}
}
}
}
}
I’ve tried making this exact mutation, supplying the proposal ID as the name input field, but it errors out on the variant level, saying it can’t return data for the proposal ID:
"message": "Exception while fetching data (/graph/variant) : Variant ddddcb97-c318-45e2-895d-54089b8268f6 not found",
"path": [
"graph",
"variant"
],
Could I be missing something here?
The proposal ID is something like p-1
I see, that makes sense. I’m now using the correct proposal ID.
Is there any reason this query would fail due to auth? I’m currently providing a Graph Admin API key as the X-API-KEY but getting this error
{
"message": "Exception while fetching data (/_entities[0]/memberships) : NOT_ALLOWED_BY_USER_ROLE",
"path": [
"graph",
"variant",
"proposal",
"proposal",
"backingVariant",
"graph",
"account",
"memberships"
],
"extensions": {
"serviceName": "identity",
"code": "DOWNSTREAM_SERVICE_ERROR"
}
},
I seemingly can only get this mutation to work if I use my own Personal API key as an org admin.
When using a Graph API Key that has Graph Admin permissions, I get the error above.
This documentation lays out that a Graph Admin or Contributor should have access to update reviewers: Members, Roles, and Permissions - Apollo GraphQL Docs
This is the level of access my graph has permission for with proposals:
@kylekrupp That appears to be a bug with the API keys, can you please raise a support request in the Help Center: https://support.apollographql.com/
Thanks for confirming @shanemyrick , adding the ticket ref here for posterity TSH-18159
Hey there @greg-apollo / @shanemyrick , I’ve been playing around with the Platform API a bit, but can’t seem to find a way to retrieve the schema diff on a given proposal.
Is there an obvious way to do that I may be missing? Or if not, is there a roundabout way I could programmatically generate the diff that is displayed in the Proposals view?
You should be able to find the diff in the ProposalImplementedChange.diffItem field: Studio
Is the only way to retrieve diff data is if the proposal is implemented? My intention is to kick off this automated reviewer requesting when a proposal is opened
Update: for my intention, I put together this query that allows me to retrieve the core document in the proposal, and the core document of the latest launch for the variant. With this information I could infer the diff and cherry pick the info I need.
query Proposal($graphId: ID!, $name: String!) {
graph(id: $graphId) {
variant(name: $name) {
name
proposal {
latestRevision {
launch {
build {
result {
... on BuildSuccess {
coreSchema {
coreDocument
}
}
}
}
}
}
sourceVariant {
latestLaunch {
build {
result {
... on BuildSuccess {
coreSchema {
coreDocument
}
}
}
}
}
}
}
}
}
}
}
It looks like you can fetch the structured diff if you have the schema hash of the old schema from the previous version of the proposal to the current
query Diff($graphId2: ID!) {
graph(id: $graphId2) {
flatDiff(newSdlHash: "", oldSdlHash: "") {
}
}
}